Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time loop and call to AEROBULK_INIT/BYE #42

Merged
merged 5 commits into from
Jun 29, 2022

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Jun 29, 2022

This strips more of the aerobulk complexity out of our fortran wrappers. We can drop the loop entirely since thanks to #40
internally we will only ever deal with 1D arrays that do not extend in the third dimension (they only have a singelton dimensions due to the restrictions aerobulk applies).

This also removes the 'auto-detection' of humidity units and strictly requires specific humidity as input.

@jbusecke jbusecke merged commit 0eae64e into xgcm:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we need AEROBULK_INIT?
1 participant