Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update team members #668

Merged
merged 14 commits into from
Dec 15, 2022
Merged

feat: update team members #668

merged 14 commits into from
Dec 15, 2022

Conversation

patricia-mdias
Copy link
Contributor

@patricia-mdias patricia-mdias commented Dec 12, 2022 •
edited
Loading

Relates to #619

Screenshots (if visual changes)

F17EB745-CB49-4904-9E38-F4FD7A09C42F
2DA8273F-C62E-4F62-B8DB-FBC5FED13234
3A32055A-591B-4F0B-A3DE-77327B9CFF75

Proposed Changes

  • Team admin, super admins and stakeholders can add and/or remove team members.
  • Team admin and stakeholder can't edit their own new joiner status.
  • Change wording on adding/removing team members. The component used to remove and add members, but only said add team members - the success toast: team members added (when they were removed and/or added).

@CatiaAntunes96

This pull request closes #619

@patricia-mdias patricia-mdias added enhancement New feature or request frontend labels Dec 12, 2022
@patricia-mdias patricia-mdias added this to the Full Version milestone Dec 12, 2022
@patricia-mdias patricia-mdias self-assigned this Dec 12, 2022
nunocaseiro
nunocaseiro requested changes Dec 14, 2022
View reviewed changes
frontend/src/components/Teams/CreateTeam/CardMember/index.tsx Outdated Show resolved Hide resolved
frontend/src/hooks/useTeam.tsx Outdated Show resolved Hide resolved
frontend/src/pages/teams/[teamId].tsx Outdated Show resolved Hide resolved
@nunocaseiro nunocaseiro force-pushed the feat/update-team-members branch from 8d7de56 to d88c6c7 Compare December 15, 2022 11:03
@nunocaseiro nunocaseiro force-pushed the feat/update-team-members branch from d88c6c7 to 8804c1a Compare December 15, 2022 11:07
nunocaseiro
nunocaseiro approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@patricia-mdias patricia-mdias merged commit c312589 into main Dec 15, 2022
@patricia-mdias patricia-mdias deleted the feat/update-team-members branch December 15, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@patricia-mdias patricia-mdias

Labels
enhancement New feature or request frontend
Projects
SPLIT • Frontend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[FEATURE]: update team members
2 participants
@patricia-mdias @nunocaseiro