Revert: Don't stop JobContainer on failure (nektos#1041)

xing · Mar 14, 2022 · 4d71071 · 4d71071
1 parent 1e92d87
commit 4d71071
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/pkg/runner/job_executor.go b/pkg/runner/job_executor.go
@@ -53,15 +53,14 @@ func newJobExecutor(info jobInfo) common.Executor {
 	}
 
 	steps = append(steps, func(ctx context.Context) error {
-		err := info.stopContainer()(ctx)
-		if err != nil {
-			return err
-		}
-
 		jobError := common.JobError(ctx)
 		if jobError != nil {
 			info.result("failure")
 		} else {
+			err := info.stopContainer()(ctx)
+			if err != nil {
+				return err
+			}
 			info.result("success")
 		}
 

diff --git a/pkg/runner/job_executor_test.go b/pkg/runner/job_executor_test.go
@@ -103,7 +103,6 @@ func TestNewJobExecutor(t *testing.T) {
 			executedSteps: []string{
 				"startContainer",
 				"step1",
-				"stopContainer",
 				"interpolateOutputs",
 				"closeContainer",
 			},