Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/curp client tests suits #582

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Dec 20, 2023

Subsequent PR of #584 , add tests

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 496 lines in your changes are missing coverage. Please review.

Comparison is base (fa656ad) 64.40% compared to head (dc56e3f) 78.22%.
Report is 43 commits behind head on master.

Files Patch % Lines
curp/src/client_new/unary.rs 57.74% 199 Missing ⚠️
curp/src/client_new/mod.rs 6.54% 100 Missing ⚠️
curp/src/rpc/connect.rs 1.31% 75 Missing ⚠️
curp/src/client_new/retry.rs 65.18% 47 Missing ⚠️
curp/src/client_new/tests.rs 93.91% 23 Missing ⚠️
xline/src/server/kv_server.rs 31.25% 22 Missing ⚠️
xline-client/src/clients/kv.rs 78.57% 6 Missing ⚠️
xlineapi/src/command.rs 64.70% 6 Missing ⚠️
curp/src/rpc/mod.rs 94.82% 3 Missing ⚠️
xline/src/server/command.rs 70.00% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #582       +/-   ##
===========================================
+ Coverage   64.40%   78.22%   +13.82%     
===========================================
  Files         105      158       +53     
  Lines       18802    22438     +3636     
  Branches    18802        0    -18802     
===========================================
+ Hits        12109    17552     +5443     
+ Misses       5955     4886     -1069     
+ Partials      738        0      -738     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iGxnon iGxnon force-pushed the refactor/curp-client-2 branch from e593996 to 6179691 Compare December 21, 2023 05:58
This was referenced Dec 21, 2023
@iGxnon iGxnon force-pushed the refactor/curp-client-2 branch from 29e2d4a to 7fe7933 Compare December 25, 2023 05:50
curp/src/client_new/mod.rs Show resolved Hide resolved
curp/src/client_new/tests.rs Outdated Show resolved Hide resolved
curp/src/client_new/tests.rs Show resolved Hide resolved
curp/src/client_new/tests.rs Show resolved Hide resolved
@iGxnon iGxnon force-pushed the refactor/curp-client-2 branch from 7fe7933 to 6f5b578 Compare December 25, 2023 15:14
curp/src/client_new/mod.rs Outdated Show resolved Hide resolved
curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
@iGxnon iGxnon force-pushed the refactor/curp-client-2 branch from 6f5b578 to c184db7 Compare December 29, 2023 06:56
@Phoenix500526 Phoenix500526 added this to the v0.6.1 milestone Jan 2, 2024
iGxnon added 5 commits January 3, 2024 12:55
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
@iGxnon iGxnon force-pushed the refactor/curp-client-2 branch from c184db7 to 60f6e57 Compare January 3, 2024 05:20
Signed-off-by: iGxnon <igxnon@gmail.com>
@iGxnon iGxnon force-pushed the refactor/curp-client-2 branch from 60f6e57 to dc56e3f Compare January 3, 2024 05:54
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@themanforfree themanforfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit f4ec578 into xline-kv:master Jan 5, 2024
9 checks passed
@iGxnon iGxnon deleted the refactor/curp-client-2 branch January 10, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants