-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/curp client tests suits #582
Conversation
b99b62d
to
e593996
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
===========================================
+ Coverage 64.40% 78.22% +13.82%
===========================================
Files 105 158 +53
Lines 18802 22438 +3636
Branches 18802 0 -18802
===========================================
+ Hits 12109 17552 +5443
+ Misses 5955 4886 -1069
+ Partials 738 0 -738 ☔ View full report in Codecov by Sentry. |
e593996
to
6179691
Compare
29e2d4a
to
7fe7933
Compare
7fe7933
to
6f5b578
Compare
6f5b578
to
c184db7
Compare
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
c184db7
to
60f6e57
Compare
Signed-off-by: iGxnon <igxnon@gmail.com>
60f6e57
to
dc56e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Subsequent PR of #584 , add tests
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)