-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/curp client retry #584
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #584 +/- ##
===========================================
+ Coverage 64.40% 76.64% +12.24%
===========================================
Files 105 157 +52
Lines 18802 21927 +3125
Branches 18802 0 -18802
===========================================
+ Hits 12109 16806 +4697
+ Misses 5955 5121 -834
+ Partials 738 0 -738 ☔ View full report in Codecov by Sentry. |
9be5415
to
f43bb5f
Compare
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
27d869e
to
0bb0d0b
Compare
Signed-off-by: iGxnon <igxnon@gmail.com>
0bb0d0b
to
f62a6d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on #590
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Add retry layer for curp client
what changes does this pull request make?
As above
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No