Added simple equality operator for class Symbol #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I face the same issue with |
|
thx and sorry for slow motion. |
corytodd
pushed a commit
to corytodd/jsondiff
that referenced
this pull request
Jun 2, 2023
In xlwings#55 an equality method was introduced without a corresponding hash method. Hashable objects that implement __eq__ must also implement __hash__ if the type is immutable [1]. Implement hash using the label field which is now a property in order to convey the intent of immutability. Fixes xlwings#58 [1] https://docs.python.org/3/reference/datamodel.html#object.__hash__ Signed-off-by: Cory Todd <cory.todd@canonical.com>
This was referenced Jun 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on my issue regarding the implementation of the equality operator, I did just that.
This now allows equality comparison between two
Symbolinstances and returnsTrueif theirlabelattributes are equal.