jsondiff: fix symbol equality #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2023 15:18
The hypothesis artifacts would never need to be committed. Signed-off-by: Cory Todd <cory.todd@canonical.com>
In xlwings#55 an equality method was introduced without a corresponding hash method. Hashable objects that implement __eq__ must also implement __hash__ if the type is immutable [1]. Implement hash using the label field which is now a property in order to convey the intent of immutability. Fixes xlwings#58 [1] https://docs.python.org/3/reference/datamodel.html#object.__hash__ Signed-off-by: Cory Todd <cory.todd@canonical.com>
Closed
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #55 an equality method was introduced without a corresponding hash
method. Hashable objects that implement
__eq__must also implement__hash__if the type is immutable [1]. Implement hash using the labelfield which is now a property in order to convey the intent of
immutability.
Fixes #58
[1] https://docs.python.org/3/reference/datamodel.html#object.__hash__
Signed-off-by: Cory Todd cory.todd@canonical.com