Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParseLocator: sanitize locator components #210

Closed
denopink opened this issue Oct 18, 2024 · 1 comment · Fixed by #211
Closed

ParseLocator: sanitize locator components #210

denopink opened this issue Oct 18, 2024 · 1 comment · Fixed by #211
Assignees
@denopink
Labels
bug Something isn't working

Comments

@denopink
Copy link
Contributor

Currently, parsing the following string "event: /xmidt-test/2/config" yields an authority with the value .

We probably don't want this and should sanitize each locator component removing trailing and leading whitespaces.

Example:
image
@denopink denopink added the bug Something isn't working label Oct 18, 2024
@denopink denopink self-assigned this Oct 18, 2024
@schmidtw
Copy link
Member

Please add a test case for this & fix it. That's a good find!

@denopink denopink changed the title ParseLocator to sanitize locator components ParseLocator: sanitize locator components Oct 18, 2024
denopink added a commit that referenced this issue Oct 18, 2024
@denopink
patch: ParseLocator, sanitize locator components
c6482be 
- currently, parsing the following string "event:     /xmidt-test/2/config" yields an authority with the value `     `
 - sanitize each locator component, removing trailing and leading whitespaces

#210
@denopink denopink linked a pull request Oct 18, 2024 that will close this issue
patch: ParseLocator, sanitize locator components #211
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denopink denopink

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

patch: ParseLocator, sanitize locator components xmidt-org/wrp-go
2 participants
@schmidtw @denopink