Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v3.1.0 #229

Merged
merged 46 commits into from
Jan 24, 2024
Merged

Release/v3.1.0 #229

merged 46 commits into from
Jan 24, 2024

Conversation

shuchitak
Copy link
Contributor

No description provided.

modules/drivers/usb/api/rtos_usb.h Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has XMOS made any changes in this file? If so, I will want to discuss with @tomblackie-xmos what copyright & license from XMOS apply to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of the source of this file to know if we've made any changes.

Copy link
Contributor Author

@shuchitak shuchitak Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we've made multiple releases of fwk_rtos with the existing license, my suggestion would be to leave it as is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has XMOS made any changes in this file? If so, I will want to discuss with @tomblackie-xmos what copyright & license from XMOS apply to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of the source of this file to know if we've made any changes.

modules/sw_services/usb/portable/tusb_nstackwords.S Outdated Show resolved Hide resolved
@shuchitak shuchitak requested a review from mbanth January 24, 2024 14:42
xluciano
xluciano previously approved these changes Jan 24, 2024
Copy link
Contributor

@xluciano xluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments from my side. It would be good to check with ChrisS if we can re-enable the WiFi tests before we re-release this repo.

Copy link
Collaborator

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shuchitak shuchitak merged commit 7be5724 into main Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants