Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cosmiconfig for config variety #331

Closed
wants to merge 1 commit into from
Closed

Use cosmiconfig for config variety #331

wants to merge 1 commit into from

Conversation

j0hnm4r5
Copy link

@j0hnm4r5 j0hnm4r5 commented Jun 5, 2018

Fixes #330

@j0hnm4r5
Copy link
Author

j0hnm4r5 commented Jun 5, 2018

This seems to be working so far on my machine, albeit I'm not nesting any package.jsons or .xorcs. There's a few tests failing, but I think it's because they were written specifically to check for pkg-conf's handling of the config.

Annoyingly, while using a .xorc, you have to reload VSCode if you make any changes to the config; it seems like VSCode watches .eslintrc and package.json for changes, which is why a reload isn't necessary when using those. But that's not a big deal in the grand scheme of things (and those tat want to continue doing config in package.json won't be affected at all).

@aslafy-z
Copy link

Any chance you rebase your work?

@sindresorhus
Copy link
Member

See: #279 (comment)

Can you also fix the merge conflict?

This will need some docs and test additions too.

@bunysae
Copy link

bunysae commented Feb 8, 2020

@j0hnm4r5
Do you want to do any on further work on this pull-request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support an external config file instead of just package.json config
4 participants