Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up: Use cosmiconfig #354

Closed
wants to merge 3 commits into from
Closed

Follow-up: Use cosmiconfig #354

wants to merge 3 commits into from

Conversation

aslafy-z
Copy link

Following up #279 and #331

This PR reuse #331 commits (thanks @j0hnm4r5 !). I opened it to address once and for all a very anoying issue when using lint-staged to trigger xo. I made all the tests pass, let me know if I need to add some.

Summary:

  • use cosmiconfig instead of pkg-conf to fetch xo config
  • give a relative path to findApplicableOverrides

Closes #279
Closes #331

Fixes #330

@sindresorhus
Copy link
Member

See: #279 (comment)

@pvdlg
Copy link
Contributor

pvdlg commented Dec 1, 2018

See #279 (comment). That doesn't seems to solve that problem as you still load the configuration relative to cwd here and not relative to the path of the file being linted.

@aslafy-z aslafy-z closed this Dec 1, 2018
@aslafy-z aslafy-z deleted the use-cosmiconfig branch December 1, 2018 11:25
@aslafy-z aslafy-z restored the use-cosmiconfig branch December 1, 2018 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants