-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calibrated C14 measurements are displayed with a standard error #46
Comments
That is true! For reason unclear to me, in the original development a decision was made that this is reasonable. Should be fixed to 95% conf interval, I guess? Need to be reflected in the db, the views and the api... (api 2.0?). |
I would say so yeah. I'll leave this NULL in the upcoming import, then. |
We discussed this today @MartinHinz, and agreed that it would be better to move to a confidence interval soonish (continuing to code around the Instead, we could create a table which caches the calibrated date for each combination of |
To take this up again: Since we are now using calibrator, and only display the ranges in the view, this issue is actually solved. But, we should perhaps now store the calibration results in the database so that they become searchable (e.g. for filtering by calibrated data). The following consideration: New column calibrator_json, type: json in c14s_helper
Then we can also trigger the calibration with a rake task:
|
Are you sure about coupling our data model so closely to the implementation of calibrator? What would it look like in e.g. API output? For querying I imagine all we really need is the 2 sigma range. |
The json output of calibrator is rather generic, here you get an example:
I am happy to adapt it to whatever seems to be necessary to XRONOS, since it is designed foremost with the use in XRONOS in mind (and it includes 2sigma by default, if you specify -r). How do you feel about this? |
Fair enough. We're essentially creating a submodel within a single attribute, though, which doesn't feel quite right... We could separate out the probability distribution and the sigma range into two attributes (still both jsonb). And in that case, do we really need to store the full probability distribution? Thinking at future-proofing things, as well: an uncalibrated date can potentially have multiple calibrated dates (e.g. with different calibration curves or reservoir corrections). Following this logic we could make C14Calibration its own model, which would bring some benefits in terms of sticking to CRUD (i.e. calibrating a date is creating a C14Calibration) and caching (we only need one C14Calibration for each unique combination of age, error and cal curve). |
We discussed this a few days ago and agreed that a new model is probably the way to go. @MartinHinz suggested generalising this to a "CalendarDate" that can store the calendar TAQs, TAPs, and probability distribution of any xron, which I think is a very good solution. |
E.g. in the measurements table. My understanding was that this was not meaningful since a calibrated distribution is (very) not normal?
The text was updated successfully, but these errors were encountered: