Restore functionality to data browser #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where the user provides one value to filter by bp, it should be interpreted as a query for that specific value (e.g. ?filter[c14s][bp][]=1 -> where(bp: 1..1)). Since this is probably counter-intuitive, provide default values for min and max bp in the form.
With a no-JS fallback.
Bringing back some of the angular look from OG XRONOS
Bringing it closer to the 'flat', monochrome style of the curation interface.
Showing only location (the most immediately useful set?) to begin with. Otherwise the 'filter' button is pushed off the screen most of the time.
Still not actually functional for typos or references.
|
The failing test is due to #295, not any changes here. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores most of the filters the data browser had before it was refactored #288. Also includes some stylistic improvements to the data browser and related UI elements.
The outstanding issues are: