Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposed basis for implementing #115
app/views/c14s/index.csv
)This is a different approach from our old one, of collating all models together into one. It delegates the responsibility of reconstructing our data model and flattening it into one table to the end user (if that's what they want to do). I think this is the right approach. Our data model isn't flat and trying to pretend it is tends to cause problems (e.g. #165)
That said, I do think it would be useful to pull in fields from associated records when there is a straightforward one-to-one relation (#255). Putting the site name in the c14 table, for example.
Other potential improvements/extensions: