Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulated data #254

Merged
merged 8 commits into from
Mar 22, 2023
Merged

Tabulated data #254

merged 8 commits into from
Mar 22, 2023

Conversation

joeroe
Copy link
Contributor

@joeroe joeroe commented Mar 13, 2023

My proposed basis for implementing #115

  • Adds csv as a content type that controllers can respond with
  • Adds ability to export records as CSV
  • Adds csv format to index actions of all data records
  • Adds buttons for downloading CSVs to index views of sites, c14s, typos, and references
  • Adds buttons for downloading CSVs of associated records from the C14 show view

This is a different approach from our old one, of collating all models together into one. It delegates the responsibility of reconstructing our data model and flattening it into one table to the end user (if that's what they want to do). I think this is the right approach. Our data model isn't flat and trying to pretend it is tends to cause problems (e.g. #165)

That said, I do think it would be useful to pull in fields from associated records when there is a straightforward one-to-one relation (#255). Putting the site name in the c14 table, for example.

Other potential improvements/extensions:

@joeroe joeroe merged commit 121539b into master Mar 22, 2023
@joeroe joeroe deleted the tabulate branch March 22, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants