More issues #282
More issues #282
Conversation
joeroe
commented
Mar 30, 2023
joeroe
commented
- Adds a number of 'low hanging fruit' issues from Add issues #260
- Adds parsing and validation of C14 lab codes and numbers (new LabId model)
- Adds ability to filter issue indexes using the underlying model's search interface Filter issue indexes #249 (a good template for Filtering API is missing a frontend #211)
The low-hanging fruit: MISSING_C14_AGE, VERY_OLD_C14, MISSING_C14_ERROR, MISSING_D13C, MISSING_D13C_ERROR, MISSING_C14_METHOD, MISSING_C14_LAB_ID, and MISSING_C14_LAB
Validating in the routes.
Splits out C14::LabIdentifier as a value object and adds methods for validation and extraction of lab codes and lab numbers.
I don't like it, but it's pretty common...
To fix v1 API csv building and generally avoid constant sample.material.present? etc. checks
Solves issues with c14s with nil lab IDs. Not the most pleasant model name, but having a name that collides with the attribute lab_identifier causes problems.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # GET /issues/references/:issue | ||
| def index | ||
| if params.has_key?(:issue) | ||
| @references = Reference.send(params[:issue]) |
Check failure
Code scanning / CodeQL
Code injection
| if params[:issue] == "missing" | ||
| @samples = Sample.missing | ||
| if params.has_key?(:issue) | ||
| @samples = Sample.send(params[:issue]) |
Check failure
Code scanning / CodeQL
Code injection
| # GET /issues/c14s/:issue | ||
| def index | ||
| if params.has_key?(:issue) | ||
| @c14s = C14.send(params[:issue]) |
Check failure
Code scanning / CodeQL
Code injection
| # GET /issues/sites/:issue | ||
| def index | ||
| if params.has_key?(:issue) | ||
| @sites = Site.send(params[:issue]) |
Check failure
Code scanning / CodeQL
Code injection
| if params[:issue] == "unknown_taxon" | ||
| @taxons = Taxon.unknown_taxon | ||
| if params.has_key?(:issue) | ||
| @taxons = Taxon.send(params[:issue]) |
Check failure
Code scanning / CodeQL
Code injection
|
I am going to skip review on this, because I'd like to use the new filtering interface in production ASAP. Any ensuing problems are on me, @MartinHinz! |
