-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data loss when resizing #325
Comments
Thanks for reporting @blink1073. Will take a deeper look on this. |
I've experienced the same errors as I am using xterm.js without a "real" process (I am using https://github.com/skulpt/skulpt). I am just piping in my stdin and stdout streams. |
This reverts commit dfe6836.
This reverts commit 69a3f9a.
This reverts commit 261a4fd.
I believe fixing this may fix some of the escape sequence tests. I think the reason t0021-CUB.in is failing for example is because the cursor position is reset to 0 after a line is wrapped but it should be cols. |
@Tyriar Any input on when this resizing issue will be resolve? |
Got it! Looking at it right now. |
Still working on it! :) |
@imsnif Any input on what you still need to do? |
@ppot - in short: right now in my prototype Then pull from upstream (I'm a little behind), write tests, clean everything up and we're good. Once I get the prototype to work (shouldn't be long now, I hope) I'll have a much clearer ETA of when the rest will be done. |
Fixed by #616, thanks @LucianBuzzo! |
Resizing should preserve the existing text.
Details
Steps to reproduce
Iterm2 handles this by reflowing the rows when you decrease the width.
vs.
The text was updated successfully, but these errors were encountered: