Horizontal resize screws up horizontal terminal layout

[isidorn]

#8222

1. Open integrated terminal - run some scripts which uses all the horizontal space
2. Resize vscode window horizontaly - notice how the terminal will shrink but will never re-grow
3. I would expect the terminal grows horizontally as do the other terminals

[Tyriar]

Upstream issue for prompt messing up on resize: xtermjs/xterm.js#103
Upstream issue for output messing up on resize: xtermjs/xterm.js#325

[Tyriar]

I've consolidated all issues related to horizontally resizing the viewport under this one. It's important to note that Windows seems to behave a little worse when resizing than other platforms, wrapping some lines incorrectly. These are still all upstream issues as mentioned in #8336 (comment)

[lrs]

Several months later and no update? What does "upstream" mean in this context by the way?

I only add a comment because the integrated terminal feature seems to be a major factor when considering whether to go with Code or not.

Is this a problem with Windows installations only? I can use and resize an external cmd window just fine when I exec npm run build that is watching for changes for example.

[Tyriar]

Upstream means xterm.js. There is a community member who has a PR out at the moment but it needs to be reworked after some big performance related improvements. It applies to all operating systems.

[lrs]

OK, thanks for the update.

[Tyriar]

The resize discarding data is fixed in Insiders, the data will now reappear when resized back thanks xtermjs/xterm.js#616 from @LucianBuzzo.

@LucianBuzzo also has a PR out that isn't merged just yet that adds support for reflowing the lines so they will get wrapped when the horizontal size is reduced! This is tracked in #23688