Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal: broken text layout #19665

Closed
warpdesign opened this issue Feb 1, 2017 · 108 comments
Closed

Terminal: broken text layout #19665

warpdesign opened this issue Feb 1, 2017 · 108 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues windows VS Code on Windows issues
Milestone

Comments

@warpdesign
Copy link
Contributor

warpdesign commented Feb 1, 2017

  • VSCode Version: Code - Insiders 1.9.0-insider (fcac9b6, 2017-01-31T00:57:46.157Z)
  • OS Version: Windows_NT ia32 10.0.15019
  • Extensions:
Extension Author Version
vscode-eslint dbaeumer 1.2.2
theme-dracula dracula-theme 1.2.5
vscode-great-icons emmanuelbeziat 1.1.38
Theme-azure gerane 0.0.2
theme-material-theme jprestidge 1.0.1
vs-color-picker lihui 0.3.2
Theme-MaterialKit ms-vscode 0.1.1
view-in-browser qinjia 0.0.4
ActiveFileInStatusBar RoscoP 1.0.2
eval Stormspirit 0.0.5
omnipascal Wosi 0.12.0

Steps to Reproduce:

  1. running grunt test to run unit testing should produce this output: (here in cmd.exe)

terminal_cmd

Here is what I got in VSCode integrated terminal:

terminal_code

Note that the first time I ran it, the layout of the prompt was also broken, instead of the cursor directly following the prompt, like:

cursor_ok

I was having:

cursor_bad

(and I could not move the cursor more on the left)

@Tyriar
Copy link
Member

Tyriar commented Feb 1, 2017

What's in your settings.json file and was there any errors in the dev tools console?

@Tyriar Tyriar added terminal Integrated terminal issues info-needed Issue requires more information from poster labels Feb 1, 2017
@warpdesign
Copy link
Contributor Author

There were no errors in the console.

My settings.json file:

// Place your settings in this file to overwrite the default settings
{
    "terminal.integrated.cursorBlinking": true,
    "terminal.integrated.lineHeight": 1.3,
    "workbench.editor.enablePreview": false,
    "workbench.editor.enablePreviewFromQuickOpen": false,
    "window.openFilesInNewWindow": false,
    "window.reopenFolders": "one",
    "typescript.check.tscVersion": false,
    "workbench.sideBar.location": "left",
    "window.zoomLevel": 0,
    "workbench.activityBar.visible": true,
    "terminal.integrated.shell.windows": "C:\\WINDOWS\\Sysnative\\cmd.exe",
    "terminal.integrated.rightClickCopyPaste": false
}

@warpdesign
Copy link
Contributor Author

warpdesign commented Feb 1, 2017

Here is what the inspector looks like (notice the prompt that seems to get shifted to the right (the begining of the prompt's text is in the previous div). Hope this helps.

bugterminalvscode

@warpdesign
Copy link
Contributor Author

More information: this didn't happen with VSCode 1.8.1, but happens with the latest final 1.9 build as well.

Running a simple sudo apt-get install package is enough to trigger the problem:

bug_terminal

@CaselIT
Copy link

CaselIT commented Feb 3, 2017

I have the same issue, when using mocha to test something.
If needed I can add a simple repo to reproduce

Below is my configuration:

  • VSCode Version: Code 1.9.0 (27240e7, 2017-02-02T08:31:00.827Z)
  • OS Version: Windows_NT ia32 10.0.15019
  • Extensions:
Extension Author Version
python donjayamanne 0.5.8
tslint eg2 0.8.1
docthis joelday 0.3.10
PowerShell ms-vscode 0.9.0
typescript-javascript-grammar ms-vscode 0.0.18

@CaselIT
Copy link

CaselIT commented Feb 3, 2017

I've noticed that both @waderyan and me are running Windows 10 preview 15019.
I've tried to reproduce it on a normal version of windows 10 and could not. So the fault may be in the preview of windows.

Below is the configuration of my other machine where I could not reproduce the bug

  • VSCode Version: Code 1.9.0 (27240e7, 2017-02-02T08:31:00.827Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
python donjayamanne 0.5.6
tslint eg2 0.8.1
vscode-npm-script eg2 0.1.8
docthis joelday 0.3.10
vscode-filesize mkxml 1.0.0
PowerShell ms-vscode 0.9.0
typescript-javascript-grammar ms-vscode 0.0.18

Hope it helps

@CaselIT
Copy link

CaselIT commented Feb 3, 2017

I'm able to reproduce it on another pc with windows 15019

@Tyriar
Copy link
Member

Tyriar commented Feb 4, 2017

This could be related to the terminal not printing unicode characters correctly #19763? If you can reproduce what locale are you using? Could you also post a screenshot of VS Code terminal bad output via good output in cmd?

@Tyriar Tyriar added the windows VS Code on Windows issues label Feb 4, 2017
@CaselIT
Copy link

CaselIT commented Feb 4, 2017

My locale is us. The normal terminal works fine
image
I've noticed that the problem occurs only when the terminal is larger than about 1200px see images:
Here is fine and the terminal is 1208px
image
here it does not render correctly, the size is 1240px
image
(my screen size is 1440p, so 2560px horizontally )
Let me know if you need some other tests

@CaselIT
Copy link

CaselIT commented Feb 4, 2017

Also resizing the window horizontally causes multiple times randomly problems
In the output below is should be as in the images in the previous post
image

@Tyriar
Copy link
Member

Tyriar commented Feb 4, 2017

Do you see the problem only after resizing? Maybe related to #8336

@CaselIT
Copy link

CaselIT commented Feb 4, 2017

The one in the last image yes.
The other problems are always there if the terminal is larger than about 1200px. (I don't know if the measure is connected to the screen resolution)

@CaselIT
Copy link

CaselIT commented Feb 4, 2017

I've tried on my other pc, that has a screen of 1600x900px and the behavior is the same, above about 1200px the terminal has problems.

@Tyriar Tyriar added this to the Backlog milestone Feb 6, 2017
@CaselIT
Copy link

CaselIT commented Feb 9, 2017

I've updated on v1.9.1 and the issue is still there.

@warpdesign
Copy link
Contributor Author

Update: I'm still having the problem with latest VSCode insider (2017-02-10T07:10:40.518Z) & latest Windows 10 insider build (15031).

@asvetliakov
Copy link

asvetliakov commented Feb 10, 2017

Actually the terminal is unusable for me:
capture

@fess932
Copy link

fess932 commented Feb 13, 2017

Actually the terminal is unusable for me too:
r4d4h2c 1

@CaselIT
Copy link

CaselIT commented Feb 13, 2017

@fess932 @asvetliakov are you both using win 10 preview like me and @warpdesign ?

@fess932
Copy link

fess932 commented Feb 13, 2017

@CaselIT Yes. This problem is only in win 10 preview?

@CaselIT
Copy link

CaselIT commented Feb 13, 2017

It appears to be from the people on this issue. Also I've tries using same vscode version and the same terminal command and on the preview I have the problem while on the normal win10 version I have not.

@warpdesign
Copy link
Contributor Author

@CaselIT @fess932 I am using win 10 preview too.

Note that with cmd.exe there are no such problems.

@CaselIT
Copy link

CaselIT commented Feb 13, 2017

Note that with cmd.exe there are no such problems.

Sadly I have them also using cmd.

@warpdesign
Copy link
Contributor Author

@Tyriar What's the status of this bug? Do you need more information?

It really makes the terminal difficult to use since most commands will break the output like this.

It seems to happen only in insider builds but the final "Creators Update" update is supposed to be released in a few weeks only.

@Tyriar
Copy link
Member

Tyriar commented Mar 1, 2017

@warpdesign I haven't been able to repro, if it's related to Insiders then that's the reason.

@miniksa @bitcrazed any idea what this could be related to? It only appears to happen on Window Insiders.

@bitcrazed
Copy link

@Tyriar This also appears to repro in 14393 as per @CaselIT's report above.

Struggling to repro here.

Can someone pipe command output into a file that can be echoed locally to repro? Or perhaps provide a minimalist repro?

@emeryao
Copy link

emeryao commented May 26, 2017

Hi all
I think this issue is gone since KB4020102 has been released which fixes the non-unicode issue for windows10

VS Code terminal now works well on my machine with Windows10 ‪15063.332‬

VS Code Version 1.13.0-insider
Commit 770206a
Date 2017-05-26T05:14:23.944Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0

@AndreiGorlov
Copy link

AndreiGorlov commented May 26, 2017

KB4020102 partially fixed issue for me.

Windows 10 RUS:
1
Windows 10 RUS + ENG lang pack:
2
Windows 10 RUS + ENG lang pack with cyrillic characters in terminal:
3

Locale in all cases is ru-RU, only windows gui language is different.

upd:
Version 1.12.2
Commit 19222cd
Date 2017-05-10T13:20:36.315Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0

@Kenya-West
Copy link

Kenya-West commented May 26, 2017

@emeryao @AndreiGorlov when will this update be shipped on Windows 10? I'm afraid to install it manually.
And I check and Settigs app - there's no such update.

UPD: Just go to Settings -> Updates -> Check Updates. It will come immediately. Now works very good.
Windows 10 RUS, VS code 1.12.2
Problem is now solved!

vs_code_broken_layout_terminal_1
vs_code_broken_layout_terminal_2

@StarpTech
Copy link

StarpTech commented May 26, 2017

yes update KB4020102 also fixed it for me but I couldn't install it at the first time. You have to drive through a real microsoft experience 💃 https://www.drivereasy.com/knowledge/windows-update-error-0x80248007-in-windows-10/

@miniksa
Copy link
Member

miniksa commented May 26, 2017

OK, MSFT:10187355 like I mentioned way up above in this thread transformed into MSFT:11721571 and was packaged as a part of the KB4020102 update yesterday as some of you have already discovered. The fix included in the KB repaired some of the API calls to retrieve console buffer output to match their "Legacy console" or v1 behaviors. Hopefully this resolves some of the issues you all are experiencing.

For a bit of insight as to why this is such an enormously complicated problem and why it took a while to fix, you can check out rprichard/winpty#105 (comment).

@xakep139
Copy link

xakep139 commented Jun 7, 2017

Similar issue that was fixed in Jest: jestjs/jest#3626

@leitwolf
Copy link

leitwolf commented Jun 9, 2017

KB4020102 fixed it for me, thanks.

@kidlj
Copy link

kidlj commented Jun 9, 2017

KB4020102 fixed it for me, thanks +1

@BetaMee
Copy link

BetaMee commented Jun 10, 2017

I have been concerned about this issue for a long time. This afternoon I updated new VS Code Version and I found intergrated terminal is OK . Is this issue fixed by VS Code team or OS update (KB4020102 ) ?
@Tyriar

@Tyriar Tyriar mentioned this issue Jun 12, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2017

@BetaMee the issue was caused by the Windows Creators Update and fixed in KB4020102 (see #19665 (comment))

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2017

Reports of this issue have slowed down significantly so I'm assuming that means most people have received the Windows patch and all is well. Thanks @miniksa for handling this 😃

If you are still experiencing this issue, please make sure you fully update Windows 10 before reaching out to us.

@Tyriar Tyriar closed this as completed Jun 26, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests