Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serious perf issues on master #4158

Closed
jerch opened this issue Sep 28, 2022 · 4 comments · Fixed by #4159
Closed

serious perf issues on master #4158

jerch opened this issue Sep 28, 2022 · 4 comments · Fixed by #4159

Comments

@jerch
Copy link
Member

jerch commented Sep 28, 2022

Master currently has serious perf issues (comparing ls -lR /usr on my machine, all with webgl renderer):

  • master
    grafik

  • version 5.0
    grafik

  • version 4.19
    grafik

All were measured after several runs to give JIT a chance to do its work. It seems the change causing this happened after 5.0.0.

@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2022

Can repro, runtime is similar on my machine but there's a lot more scripting time on master. Looking into it


First run after reload:

5.0.0 (checked out tag)

Screen Shot 2022-09-28 at 8 24 24 am

master

Screen Shot 2022-09-28 at 8 27 32 am


Second after reload (JIT done, buffer full):

5.0.0 (checked out tag)

Screen Shot 2022-09-28 at 8 32 30 am

master

Screen Shot 2022-09-28 at 8 30 13 am

@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2022

5.0.0

Screen Shot 2022-09-28 at 8 34 11 am

master

Screen Shot 2022-09-28 at 8 34 51 am

@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2022

The microtask change is causing the buffer to get flushed immediately, so that happens multiple times per frame instead of batching.

image

@Tyriar
Copy link
Member

Tyriar commented Sep 28, 2022

Will see if we can get the best of both worlds; microtask when there's little data to possibly improve input latency, otherwise timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants