Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak buffering in server.js #4160

Merged
merged 4 commits into from
Oct 1, 2022
Merged

tweak buffering in server.js #4160

merged 4 commits into from
Oct 1, 2022

Conversation

jerch
Copy link
Member

@jerch jerch commented Sep 28, 2022

Part2 fix of #4158.

@jerch
Copy link
Member Author

jerch commented Sep 28, 2022 •
edited
Loading

@Tyriar I'd say - its back on the fast track.

grafik

What I changed:

  • reduce timeout to 2ms reverted to 5ms (saves ~30% script runtime for output intensive calls)
  • introduce a 2^18 chunk limit
  • userInput flag to skip buffering after receiving

You might want to check, if the input latency stays low. If not, then there is a catch hidden somewhere 😅

@jerch jerch requested a review from Tyriar September 28, 2022 18:14
@jerch jerch marked this pull request as ready for review September 28, 2022 18:16
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 1, 2022
@Tyriar Tyriar merged commit e3e3c34 into xtermjs:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jerch @Tyriar