-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider XON/XOFF PR to keep slave in sync with terminal #425
Comments
I think pausing the process once a certain threshold is hit so xterm.js can catch up is the best thing to do here. The threshold could be quite large as well, say 1000+ lines or something, it's just commands that send a tonne of output will always outrun us. |
Should we consider implementing this eventually? I think that after #422 performance improved radically and I am quite skeptical about this as it seems more like a hack, rather an actual performance improvement. |
This is a must imo after looking into perf over the last week. Running a command such as |
See if #146 performs better after #422 lands. It could also be changed to let larger chunks of data (~1 viewport page?) as that should suffice for keeping ctrl+c more responsive as well as making commands such as
time
accurate.The text was updated successfully, but these errors were encountered: