Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider XON/XOFF PR to keep slave in sync with terminal #425

Closed
Tyriar opened this issue Dec 24, 2016 · 3 comments
Closed

Reconsider XON/XOFF PR to keep slave in sync with terminal #425

Tyriar opened this issue Dec 24, 2016 · 3 comments
Assignees
Labels
type/proposal A proposal that needs some discussion before proceeding

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 24, 2016

See if #146 performs better after #422 lands. It could also be changed to let larger chunks of data (~1 viewport page?) as that should suffice for keeping ctrl+c more responsive as well as making commands such as time accurate.

@Tyriar Tyriar added the type/proposal A proposal that needs some discussion before proceeding label Dec 24, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Jan 3, 2017

I think pausing the process once a certain threshold is hit so xterm.js can catch up is the best thing to do here. The threshold could be quite large as well, say 1000+ lines or something, it's just commands that send a tonne of output will always outrun us.

@Tyriar Tyriar changed the title Reconsider XON/XOFF PR to keep slave in sync with terminal after CircularList lands Reconsider XON/XOFF PR to keep slave in sync with terminal Jan 3, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jan 3, 2017
@Tyriar Tyriar self-assigned this Jan 3, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jan 3, 2017
@parisk
Copy link
Contributor

parisk commented Jan 8, 2017

Should we consider implementing this eventually? I think that after #422 performance improved radically and I am quite skeptical about this as it seems more like a hack, rather an actual performance improvement.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 9, 2017

This is a must imo after looking into perf over the last week. Running a command such as yes will send too much output for xterm.js to possibly handle, meaning it will be chugging as fast as it can all the time and interrupting such a process is only possible once the output has been processed. Definitely not hacky, it improves stability significantly in certain use cases in addition we support XON (ctrl+s) and XOFF (ctrl+q)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal A proposal that needs some discussion before proceeding
Projects
None yet
Development

No branches or pull requests

2 participants