Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit Viewport.refresh #445

Merged
merged 3 commits into from
Jan 9, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 3, 2017

This prevents 1000 scroll events from firing when the buffer is not full

Fixes #444


Notes:

The following before/after timelines were taken with this change on top of the refresh queue PR #438:

Before:

image

After:

image

This prevents 1000 scroll events from firing when the buffer is not full

Fixes xtermjs#444
@Tyriar Tyriar added this to the 2.3.0 milestone Jan 3, 2017
@Tyriar Tyriar self-assigned this Jan 3, 2017
@Tyriar Tyriar requested a review from parisk January 3, 2017 19:20
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Tyriar Tyriar merged commit 3457b73 into xtermjs:master Jan 9, 2017
@Tyriar Tyriar deleted the 444_rate_limit_viewport_refresh branch January 9, 2017 00:24
@Tyriar Tyriar restored the 444_rate_limit_viewport_refresh branch January 9, 2017 00:46
@Tyriar Tyriar modified the milestone: 2.3.0 Feb 2, 2017
@Tyriar Tyriar deleted the 444_rate_limit_viewport_refresh branch February 3, 2017 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commands that fill a non-full buffer lock up the terminal for a couple of seconds
2 participants