Rate limit Viewport.refresh #445

Tyriar · 2017-01-03T19:20:12Z

This prevents 1000 scroll events from firing when the buffer is not full

Fixes #444

Notes:

There is still lag when running long commands such as yes, this will be fixed by providing a pause/catch up mechanism as part of Reconsider XON/XOFF PR to keep slave in sync with terminal #425
I didn't bother with the size caching stuff as it's being replaced in Style wide characters at charWidth*2 in DOM #440

The following before/after timelines were taken with this change on top of the refresh queue PR #438:

Before:

After:

This prevents 1000 scroll events from firing when the buffer is not full Fixes xtermjs#444

parisk

LGTM 👍

Rate limit Viewport.refresh

6ffb8f5

This prevents 1000 scroll events from firing when the buffer is not full Fixes xtermjs#444

Tyriar added this to the 2.3.0 milestone Jan 3, 2017

Tyriar self-assigned this Jan 3, 2017

Tyriar requested a review from parisk January 3, 2017 19:20

Tyriar mentioned this pull request Jan 3, 2017

Improve xterm.js performance microsoft/vscode#17875

Closed

10 tasks

Tyriar added 2 commits January 3, 2017 11:23

jsdoc

efdf37b

Fix tests

ff523bf

parisk approved these changes Jan 8, 2017

View reviewed changes

Tyriar merged commit 3457b73 into xtermjs:master Jan 9, 2017

Tyriar deleted the 444_rate_limit_viewport_refresh branch January 9, 2017 00:24

Tyriar restored the 444_rate_limit_viewport_refresh branch January 9, 2017 00:46

Tyriar mentioned this pull request Jan 9, 2017

Revert "Rate limit Viewport.refresh" #463

Merged

Tyriar modified the milestone: 2.3.0 Feb 2, 2017

Tyriar deleted the 444_rate_limit_viewport_refresh branch February 3, 2017 05:06

Provide feedback