-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
True color support #1895
True color support #1895
Conversation
@Tyriar I am not sure about the canvas renderer whether it should be applied there at all, since it is a drop candidate. Any thoughts on this? |
@jerch 😍 I think we should, the canvas renderer will likely take months to phase out (iff there are no issues with webgl). |
canvas renderer has now preliminary RGB support. This is only hacked in for now and bypasses the cache, several conditions like inverting fg/bg does not work yet. |
Transition of the canvas renderer is done. RGB is for now always uncached, not sure if we ever want to cache those, the sheer amount of colors will invalidate the cache entries often. Might still be worth to try since most use cases will still only use a small set of colors. Technically this PR is ready for review, but I think we should get the pending PRs it relies on done first. In the meantime I gonna cleanup the new code and do more tests. The latter is cumbersome since we have no automated canvas tests at all. Maybe we get something rolling with node-canvas? |
@jerch some conflicts are stacking up on this one. |
Fixed a lot of merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR to finally get true color support. Fixes #484.
Steps to get this done:
With this PR xterm.js will support true color in the semicolon notation like CSI 38 ; 2 ; R ; G ; B m.
To be more in line with the spec the parser has to be extended to support the colon notation. It will not be covered with this PR.
This PR relies on #1878, most of the commit are from there. The true color changes start with commit c444eeb.