Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

True color support #1895

Merged
merged 25 commits into from
Apr 7, 2019
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
c444eeb
RGB support in buffer and attributes
jerch Jan 13, 2019
70ded42
follow naming scheme
jerch Jan 13, 2019
3515c0b
DOM renderer with RGB support
jerch Jan 13, 2019
0802582
test cases for DOM renderer style changes
jerch Jan 14, 2019
9cf479b
cleanup rgb channel conversion
jerch Jan 14, 2019
94c19fb
preliminarly RGB support in canvas renderer
jerch Jan 15, 2019
1536e79
remove printf remnant
jerch Jan 15, 2019
ae50d84
fix characterjoiner to support AttrData
jerch Jan 16, 2019
8d850d6
apply CellData to canvas renderer
jerch Jan 17, 2019
df739ab
remove old color and flag shims
jerch Jan 17, 2019
2370038
always draw RGB uncached
jerch Jan 17, 2019
b13b737
Merge branch 'master' into true_color
jerch Jan 17, 2019
e6447bc
Merge branch 'master' into true_color
jerch Jan 25, 2019
7da40b9
Merge branch 'utf32_buffer' into true_color
jerch Jan 31, 2019
c4a5e08
Merge branch 'utf32_buffer' into true_color
jerch Jan 31, 2019
c2446df
Merge branch 'utf32_buffer' into true_color
jerch Feb 1, 2019
0c54b1a
Merge branch 'master' into true_color
jerch Feb 1, 2019
65dbf88
apply bright shift for uncached draws
jerch Feb 1, 2019
8d4da3c
Merge branch 'master' into pr/jerch/1895
Tyriar Apr 2, 2019
e6333bd
Merge branch 'master' into true_color
Tyriar Apr 3, 2019
46f3b3f
Merge branch 'master' into true_color
Tyriar Apr 4, 2019
27283e4
Merge branch 'master' into true_color
Tyriar Apr 6, 2019
bb324ba
Move width shift back into enum
Tyriar Apr 6, 2019
171b933
Make BufferLine enums const
Tyriar Apr 6, 2019
09a5fd4
Fix capitalization in color mode
Tyriar Apr 6, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
apply bright shift for uncached draws
  • Loading branch information
jerch committed Feb 1, 2019

Verified

This commit was signed with the committer’s verified signature.
frapell Franco Pellegrini
commit 65dbf88460853785ce259131ea788980b25b1b84
6 changes: 5 additions & 1 deletion src/renderer/BaseRenderLayer.ts
Original file line number Diff line number Diff line change
@@ -325,7 +325,11 @@ export abstract class BaseRenderLayer implements IRenderLayer {
} else if (cell.isFgRGB()) {
this._ctx.fillStyle = `rgb(${AttributeData.toColorRGB(cell.getFgColor()).join(',')})`;
} else if (cell.isFgPalette()) {
this._ctx.fillStyle = this._colors.ansi[cell.getFgColor()].css;
let fg = cell.getFgColor();
if (terminal.options.drawBoldTextInBrightColors && cell.isBold() && fg < 8) {
fg += 8;
}
this._ctx.fillStyle = this._colors.ansi[fg].css;
}

this._clipRow(terminal, y);