Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4408
Description:
I found this transparent foreground color will affect some text when the foreground is background
And inside the
TextureAtlas
, there are already exist some check for background transparentSo I put another check foreground transparent
Hope this make scenes
Any feedbacks is welcome, thanks
Screenshot:
For local test, I change the xtermjsTheme foreground color with transparent
And the when no doing anything, it looks like:
After change: