Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transparent foreground color #4667

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Fix transparent foreground color #4667

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb7349b
Fix transparent foreground color
Dennnnny Aug 12, 2023
bef8740
Fix force transparent foreground colors to be opaque
Dennnnny Aug 13, 2023
855e911
Fix transparent foreground color
Dennnnny Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser/renderer/shared/TextureAtlas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ export class TextureAtlas implements ITextureAtlas {
}

private _getBackgroundColor(bgColorMode: number, bgColor: number, inverse: boolean, dim: boolean): IColor {
if (this._config.allowTransparency) {
if (this._config.allowTransparency || (inverse && !color.isOpaque(this._config.colors.foreground))) {
Tyriar marked this conversation as resolved.
Show resolved Hide resolved
// The background color might have some transparency, so we need to render it as fully
// transparent in the atlas. Otherwise we'd end up drawing the transparent background twice
// around the anti-aliased edges of the glyph, and it would look too dark.
Expand Down