Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links sometimes not activating #5171

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Fix links sometimes not activating #5171

merged 1 commit into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. Fix links sometimes not activating

    This was a very long standing bug that was hard to nail down a repro case. Turns
    out this was because at some point the current link can get cleared and re-evaluated,
    I think because of a different fix we made. That caused the object check to fail.
    So the fix there is to check link equality, not js object equality.
    
    Additionally I found we don't dispose of old linkifiers when open is called
    multiple times.
    
    See microsoft/vscode#230010
    Tyriar committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f764c0a View commit details
    Browse the repository at this point in the history