Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connector for Comments #5

Closed
12 tasks done
frankiejarrett opened this issue Nov 27, 2013 · 4 comments
Closed
12 tasks done

Add connector for Comments #5

frankiejarrett opened this issue Nov 27, 2013 · 4 comments
Assignees

Comments

@frankiejarrett
Copy link
Contributor

Comment actions should be added as a core context of the Stream plugin.

Possible actions:

  • Created
  • Updated
  • Replied
  • Approved
  • Unapproved
  • Spammed
  • Unspammed
  • Trashed
  • Untrashed
  • Deleted
  • Comment Flooding
  • Duplicate comment attempt
@ghost ghost assigned shadyvb Dec 9, 2013
@shadyvb
Copy link
Contributor

shadyvb commented Dec 15, 2013

Added Comment flooding since WP checks for the last commit you have before allowing you to post a new comment.

@shadyvb
Copy link
Contributor

shadyvb commented Dec 15, 2013

@fjarrett Regarding 'Comment::Replied' action, would it be stored as a single record if a user replied to a comment, or would a 'Comment::Created' record be created as well ? I took the approach of not adding the 'Created' record in this scenario, hopefully it'd be mitigated by users ( or extensions 👍 ) querying the database.

@shadyvb
Copy link
Contributor

shadyvb commented Dec 15, 2013

@fjarrett Actually the same thing happens with 'Comment::Approved' since some comments would get approved automatically on insertion, while others would not. I think this scenario requires an explicit second record for the approval action, to make it easy for users to query such actions, otherwise the query for approvals would need to check meta table for comment_approved meta field. Thoughts ?

@shadyvb
Copy link
Contributor

shadyvb commented Dec 15, 2013

@fjarrett Final result:

  • Adding a comment, while auto-approve is on, triggers two records ( created / approved )
  • Adding a reply, adds an extra records ( 2 or 3 records per reply, depending on auto-approve )

Let me know what do you think should happen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants