Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track all comment lifecycle/operations. Closes #5 #89

Merged
merged 6 commits into from
Dec 20, 2013
Merged

Conversation

shadyvb
Copy link
Contributor

@shadyvb shadyvb commented Dec 15, 2013

@fjarrett Please review, see #5

@ghost ghost assigned frankiejarrett Dec 16, 2013
@frankiejarrett
Copy link
Contributor

@shadyvb Please see my latest changes and test. Since some blogs may not require user registration to comment, and even some may not require name or e-mail, these scenarios needed to be taken into consideration.

I think my latest commit fully addresses them, but it needs another pair of eyes to test it. Thank you!

@ghost ghost assigned shadyvb Dec 18, 2013
@frankiejarrett
Copy link
Contributor

@shadyvb I think we should merge this. But it might be good to have you do a sanity test first just to be sure.

@jonathanbardo
Copy link
Contributor

From my testing, I found that nothing is log when approving or unapproving comments.

@jonathanbardo
Copy link
Contributor

When we are in the comment spam view. There is no action log if a user click on the "not spam" button.

@ghost ghost assigned jonathanbardo Dec 19, 2013
@frankiejarrett
Copy link
Contributor

@jonathanbardo Please test again, I addressed these issues in 2a344cf

@jonathanbardo
Copy link
Contributor

There was a little undefined variable fixed in 9be891c
comments__wordpress_develop__wordpress

@jonathanbardo
Copy link
Contributor

@fjarrett This is ready to go from my perspective.

frankiejarrett added a commit that referenced this pull request Dec 20, 2013
Track all comment lifecycle/operations. Closes #5
@frankiejarrett frankiejarrett merged commit 07f4691 into master Dec 20, 2013
@frankiejarrett frankiejarrett deleted the issue-5 branch December 20, 2013 04:08
frankiejarrett added a commit that referenced this pull request Aug 22, 2014
Issue 85: Dynamically change alert number when deleting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants