Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.5.0 #1107

Merged
merged 103 commits into from
Jul 8, 2020
Merged

Version 3.5.0 #1107

merged 103 commits into from
Jul 8, 2020

Conversation

kasparsd
Copy link
Contributor

@kasparsd kasparsd commented Jun 11, 2020

Diff: https://github.com/xwp/stream/compare/tags/3.4.3..release/next

Notable bugfixes and features included in this realease:

Release Changelog:

  • Inline PHP documentation improvements, props @kidunot89.
  • WordPress coding standard fixes, props @kidunot89.
  • TODO: bugfixes.

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

kasparsd and others added 30 commits July 25, 2019 11:26
* We can never know if cron is actually not used
* Ignore the front-end WP cron setting and check for the actual CRON request
* Reference the front-end nature of the default cron runner
…into develop

# Conflicts:
#	ui/js/exclude.js
# Conflicts:
#	tests/tests/test-class-log.php
Co-authored-by: Renovate Bot <renovatebot@gmail.com>
Bumps [acorn](https://github.com/acornjs/acorn) from 7.1.0 to 7.1.1.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@7.1.0...7.1.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kasparsd kasparsd changed the title [WIP] Version 3.4.4 [WIP] Version 3.5.0 Jul 7, 2020
@kasparsd kasparsd changed the title [WIP] Version 3.5.0 Version 3.5.0 Jul 7, 2020
@kasparsd kasparsd requested a review from kidunot89 July 7, 2020 10:58
@kasparsd
Copy link
Contributor Author

kasparsd commented Jul 7, 2020

@kidunot89 Could you please smoke test this branch locally -- run linter and unit tests, use WP dev environment and confirm that logs are being populated as expected?

@kasparsd kasparsd self-assigned this Jul 7, 2020
case 'agent':
$getter = "get_{$name}";
return $this->$getter();
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if this is tested or not.

@kidunot89 kidunot89 self-requested a review July 7, 2020 19:31
Copy link
Contributor

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasparsd 👍 Everything working on my local machine

@kasparsd kasparsd merged commit f939e46 into master Jul 8, 2020
@kasparsd kasparsd deleted the release/next branch July 8, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants