Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Yoast deprecated method conditionally #1603

Conversation

marcinkrzeminski
Copy link
Collaborator

Fixes #1594

Checklist

  • I have tested the changes in the local development environment (see contributing.md).

Release Changelog

  • Fix: Use \WPSEO_Metabox::translate_meta_boxes() conditionally to prevent logging warnings.

Copy link
Member

@pereirinha pereirinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcinkrzeminski

I've tested this with Yoast 23.6, and it's working as expected. No more deprecated warnings in the logs.
The only non-blocking suggestion would be to update the Yoast plugin so that the issue becomes more prominent.

@marcinkrzeminski marcinkrzeminski merged commit b4cd90f into develop Oct 10, 2024
1 check passed
@marcinkrzeminski marcinkrzeminski deleted the 1594-function-wpseo_metaboxtranslate_meta_boxes-is-deprecated-since-version-yoast-seo-235-with-no-alternative-available branch October 10, 2024 15:24
@westonruter
Copy link
Contributor

Hi! Will this be included in a new Stream release soon? It would be nice to be rid of those deprecation notices.

@marcinkrzeminski
Copy link
Collaborator Author

Hey @westonruter. Yeah, it's part of 4.1 release that's coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants