-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-log-viewer: Implement MenuBar and StatusBar with JoyUI components; add JoyUI custom app theme. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Henry8192
changed the title
WIP: add vscode theme for editor
new-log-viewer: add vscode theme, menu bar and status bar
Aug 31, 2024
Henry8192
changed the title
new-log-viewer: add vscode theme, menu bar and status bar
new-log-viewer: add monaco theme, menu bar and status bar
Aug 31, 2024
junhaoliao
reviewed
Sep 1, 2024
junhaoliao
reviewed
Sep 3, 2024
# Conflicts: # new-log-viewer/src/components/Layout.tsx
junhaoliao
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's work on code organization before we proceed to the next iteration of review.
junhaoliao
reviewed
Sep 3, 2024
…ton and SmallIconButton to avoid code duplication
Co-authored-by: Junhao Liao <junhao@junhao.ca>
Co-authored-by: Junhao Liao <junhao@junhao.ca>
junhaoliao
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
junhaoliao
changed the title
new-log-viewer: add monaco theme, menu bar and status bar
new-log-viewer: Implement MenuBar and StatusBar with JoyUI components; add JoyUI custom app theme.
Sep 12, 2024
junhaoliao
added a commit
that referenced
this pull request
Sep 12, 2024
This was referenced Sep 14, 2024
This was referenced Sep 26, 2024
This was referenced Sep 27, 2024
This was referenced Sep 30, 2024
This was referenced Oct 14, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
new-log-viewer series: #45 #46 #48 #51 #52 #53 #54 #55 #56 #57
Description
App Theme
Use JoyUI components for Button, Select, and Input. In
App.js
,CssVarsProvider
is added as a root provider to provide styles for components described above.Menu Bar
Status Bar
Display status message and a button displaying current log event number.
onClick
, the button will copy the permalink of the current line to clipboard.Validation performed
Open log viewer.
Menu Bar Test
Settings Test
Click settings (gear) button, toggle theme from light, system and dark, observe the color change except the monaco editor. Set page size and verify using navigation buttons.
Navigation Test
Click the four navigation buttons. Observe the change showed in the monaco editor as well as logEventNum in browser's navigation bar. Make sure to set proper pageSize in settings.
Open File Test
Click file open button, open a jsonl file locally, observe that monaco editor opens the provided log file.
Status Bar Test
Copy Permalink To Clipboard Test
Click the blue button (Log Event [current log event num] of [total log events]), it will copy the current log event's permalink to the clipboard.