Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new-log-viewer: Add bundle size optimization tooling; Replace JoyUI path imports with default imports. #73

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

junhaoliao
Copy link
Collaborator

@junhaoliao junhaoliao commented Sep 16, 2024

References

new-log-viewer series: #45 #46 #48 #51 #52 #53 #54 #55 #56 #59 #60 #61 #62 #63 #66 #67 #68 #69 #70 #71 #72

#59 added basic UI components implemented by @mui/joy but in the code the imports are inconsistent. Some code is using the default import provided by the library while others are importing directly from the component sources.

Description

  1. Add Webpack Bundle Analyzer script and update dependencies; Add bundle-stats.json to .gitignore.
  2. Add ESLint rules to restrict imports from @mui/icons-material and @mui/joy packages.
  3. Refactor imports from '@mui/joy' for consistency.

Validation performed

  1. Ran npm run analyze:size and observed the build was successful. After building is done, the analyzer server runs and a web ui pops up in the browser showing sizes of each components in the compiled bundle.
  2. Referred to Add support for loading files, decoding them as JSONL, and formatting them using a Logback-like format string. #46 , started the debug server and loaded a sample log file. Ensured the buttons in the MenuBar and StatusBar are functional; the Setting modal rendered without any warnings; the theming toggle in the settings modal functioned as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant