This repository was archived by the owner on Aug 27, 2024. It is now read-only.
forked from ivmarkov/rust-esp32-std-demo
-
Notifications
You must be signed in to change notification settings - Fork 1
Ota demo #1
Open
MartinBroers
wants to merge
33
commits into
yaak-ai:ota_demo
Choose a base branch
from
MartinBroers:ota_demo
base: ota_demo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ota demo #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `write_only` on `spi::config::Config` for `ttgo` as it's not released yet - Fix ivmarkov#92: Convert error to `anyhow::Error` for `kaluga` feature
In the change to native build, it seems the config cfg dropped the `_config` postfix
was a typo
since yesterday ili9341 point to the embedded-hal 1.0.0-alpha9 in his last version, the compilation failed
Also updated embedded-* crates Changed code to not rely on the (nice) asynchronous added methods, but just a busy loop in a seperate thread. As we currently lack the async interruptions, we have to go with this for now. Signed-off-by: Martin Broers <martin.broers@bluebirdpower.com>
575a217
to
9f04e5c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for all the effort you put in this serial updater, exactly what I needed! I made some changes (removed the dependency on the nice interupts, since we don't have them officially in the upstream packages) and updated the underlying esp-idf repositories. I may be a bit verbose with my println!'s, but if you want them to be removed, I'm happy to.
I don't know if you are open to review this PR, but if not, then maybe others can make use of this piece of added code. Please, also let me know if I am doing something weird (with authors in the Cargo.toml for example).
I also rebased back onto the branch from ivmarkov, maybe we can upstream this as an example to his repository?
Thanks in advance,
Martin