Module Test code to support module setup is correct. #122
Conversation
michael-mclawhorn
force-pushed
the
ModuleTestCode
branch
from
c26c6f0 to
b6d47d2
Compare
|
|
||
| import spock.lang.Specification | ||
|
|
||
| abstract class ModuleSetupSpec extends Specification { |
There was a problem hiding this comment.
Description of what this base spec is for and how to use it would be good.
| configurations.stream().map( {it.getString(MODULE_NAME_KEY)}).anyMatch({it.equals(getModuleName())}) | ||
| } | ||
|
|
||
| abstract String getModuleName() |
There was a problem hiding this comment.
Javadoc on this is needed so that usage and contract is clear.
| public static final String MODULE_NAME_KEY = "moduleName" | ||
| public static final String MODULE_RESOURCE_NAME = "/moduleConfig.properties" | ||
|
|
||
| def "Test that SystemConfig loads for this module"() { |
There was a problem hiding this comment.
- "Test that" isn't helpful in the test name.
- It would be cool if the module name could be injected into here somehow? Perhaps via a
whereblock that gets it's value from thegetModuleNamemethod?
|
|
||
| def "Test that SystemConfig loads for this module"() { | ||
| expect: | ||
| SystemConfig.properties.getOrDefault("foo", "foo") == "foo" |
There was a problem hiding this comment.
It was my first test, it tested that the applicationConfig or some other piece of conflictable-config didn't prevent SystemConfig from working
I'm sure there's a better way to do this.
| SystemConfig.properties.getOrDefault("foo", "foo") == "foo" | ||
| } | ||
|
|
||
| def "Current module is loaded by ConfigResourceLoader"() { |
There was a problem hiding this comment.
Would be good to replace "Current module" with an unrolled value from a where block that could source from the getModuleName() method.
|
|
||
| def "Current module is loaded by ConfigResourceLoader"() { | ||
| setup: | ||
| List<Configuration> configurations = new ConfigResourceLoader().loadConfigurations(MODULE_RESOURCE_NAME) |
There was a problem hiding this comment.
Should MODULE_RESOURCE_NAME be fixed or should it be dynamic based on what module is being tested?
There was a problem hiding this comment.
it's baked into ModuleLoader as a private constant
| List<Configuration> configurations = new ConfigResourceLoader().loadConfigurations(MODULE_RESOURCE_NAME) | ||
|
|
||
| expect: | ||
| configurations.stream().map( {it.getString(MODULE_NAME_KEY)}).anyMatch({it.equals(getModuleName())}) |
There was a problem hiding this comment.
spacing inside the calls is a little inconsistent.
|
|
||
| class BardModuleSetupSpec extends ModuleSetupSpec { | ||
|
|
||
| String getModuleName() { |
michael-mclawhorn
force-pushed
the
ModuleTestCode
branch
from
b6d47d2 to
f739766
Compare
michael-mclawhorn
force-pushed
the
ModuleTestCode
branch
from
f739766 to
d818e87
Compare
michael-mclawhorn
force-pushed
the
ModuleTestCode
branch
from
d818e87 to
f3af0a3
Compare
michael-mclawhorn
force-pushed
the
ModuleTestCode
branch
from
f3af0a3 to
cebe7ae
Compare
| * | ||
| * @return The name of the module as configured in moduleConfig.properties | ||
| */ | ||
| abstract String getModuleName() |
There was a problem hiding this comment.
Maybe we should move this to higher in the file so that people see this first.
michael-mclawhorn
force-pushed
the
ModuleTestCode
branch
from
ae5cff1 to
3336ae6
Compare
No description provided.