Module Test code to support module setup is correct.

CHANGELOG.md

@@ -39,6 +39,9 @@ Current
 - [Add ability for `ClassScanner` to instantiate arrays](https://github.com/yahoo/fili/pull/107)
     * This allows for more robust testing of classes that make use of arrays in their constructor parameters
 
+- [Add module load test code](https://github.com/yahoo/fili/pull/122)
+    * Code to automatically test module is correctly configured.
+
 ### Changed:
 
 - [MetricMaker cleanup and simplification](https://github.com/yahoo/fili/pull/127)

fili-core/src/test/groovy/com/yahoo/bard/systemconfig/BardModuleSetupSpec.groovy

@@ -0,0 +1,11 @@
+// Copyright 2016 Yahoo Inc.
+// Licensed under the terms of the Apache license. Please see LICENSE.md file distributed with this work for terms.
+package com.yahoo.bard.systemconfig
+
+class BardModuleSetupSpec extends ModuleSetupSpec {
+
+    @Override
+    String getModuleName() {
+        return "fili-core"
+    }
+}

fili-core/src/test/groovy/com/yahoo/bard/systemconfig/ModuleSetupSpec.groovy

@@ -0,0 +1,50 @@
+// Copyright 2016 Yahoo Inc.
+// Licensed under the terms of the Apache license. Please see LICENSE.md file distributed with this work for terms.
+package com.yahoo.bard.systemconfig
+
+import static com.yahoo.bard.webservice.config.ModuleLoader.MODULE_CONFIG_FILE_NAME
+
+import com.yahoo.bard.webservice.config.ConfigResourceLoader
+import com.yahoo.bard.webservice.config.SystemConfigProvider
+
+import org.apache.commons.configuration.Configuration
+
+import spock.lang.Specification
+import spock.lang.Unroll
+/**
+ * An abstract base TCK test for modules.
+ * Usage:  Subclass this spec, in test/groovy/ packages, implementing getModuleName() with your module's name.
+ */
+abstract class ModuleSetupSpec extends Specification {
+
+    public static final String MODULE_NAME_KEY = "moduleName"
+
+    /**
+     * Implement this test by supplying a subclass that provides the name of the module
+     *
+     * @return  The name of the module as configured in moduleConfig.properties
+     */
+    abstract String getModuleName()
+
+    @Unroll
+    def "#moduleName does not break SystemConfig"() {
+        expect:
+        SystemConfigProvider.instance.runtimeProperties.getOrDefault("Does getting a property throw an exception?", "foo") == "foo"
+
+        where:
+        moduleName << [getModuleName()]
+    }
+
+    @Unroll
+    def "ConfigResourceLoader discovers #moduleName"() {
+        setup:
+        List<Configuration> configurations = new ConfigResourceLoader().loadConfigurations(MODULE_CONFIG_FILE_NAME)
+
+        expect:
+        configurations.stream().map( {it.getString(MODULE_NAME_KEY)}).anyMatch({it.equals(getModuleName())})
+
+        where:
+        moduleName << [getModuleName()]
+    }
+
+}

fili-system-config/src/main/java/com/yahoo/bard/webservice/config/ModuleLoader.java

@@ -30,7 +30,7 @@ public class ModuleLoader {
     /**
      * The file name pattern describing module configuration files.
      */
-    private static final String MODULE_CONFIG_FILE_NAME = "/moduleConfig.properties";
+    public static final String MODULE_CONFIG_FILE_NAME = "/moduleConfig.properties";
 
     private static final String MODULE_NAME_IS_TOO_SHORT = "Module name is too short.";