Have Table Endpoint Filter Using QueryPlanningConstraint #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QubitPi
force-pushed
the
getLogicalTableFullView-with-TablesApiRequest
branch
from
c9b578c to
04eff7e
Compare
QubitPi
force-pushed
the
getLogicalTableFullView-with-filter
branch
from
2dcf411 to
3f660a3
Compare
QubitPi
force-pushed
the
getLogicalTableFullView-with-TablesApiRequest
branch
from
04eff7e to
1c72507
Compare
kevinhinterlong
previously requested changes
Aug 2, 2017
| @Context UriInfo uriInfo, | ||
| @Context final ContainerRequestContext containerRequestContext | ||
| ) { | ||
| RequestLog.startTiming(this); |
There was a problem hiding this comment.
Everything should be under the try block.
The constructor for TablesApiRequest can throw BadApiRequestException which would cause us to never close the timer. Related to #362
QubitPi
force-pushed
the
getLogicalTableFullView-with-TablesApiRequest
branch
3 times, most recently
from
02517a8 to
c3ecb49
Compare
QubitPi
force-pushed
the
getLogicalTableFullView-with-filter
branch
2 times, most recently
from
ac7b631 to
fc613e5
Compare
QubitPi
changed the base branch from
getLogicalTableFullView-with-TablesApiRequest
to
master
QubitPi
force-pushed
the
getLogicalTableFullView-with-filter
branch
from
fc613e5 to
f800dd4
Compare
QubitPi
force-pushed
the
getLogicalTableFullView-with-filter
branch
from
5479a66 to
b33c0db
Compare
QubitPi
force-pushed
the
getLogicalTableFullView-with-filter
branch
from
a01ff04 to
d4d406e
Compare
QubitPi
force-pushed
the
getLogicalTableFullView-with-filter
branch
from
c33f603 to
2466ea0
Compare
QubitPi
changed the title
QubitPi
force-pushed
the
getLogicalTableFullView-with-filter
branch
from
2466ea0 to
f78aad5
Compare
michael-mclawhorn
approved these changes
Oct 31, 2017
| @@ -259,7 +261,9 @@ | |||
|
|
|||
| UNABLE_TO_CREATE_DIR("Unable to create directory %s."), | |||
| UNABLE_TO_DELETE_DIR("Unable to delete directory %s."), | |||
| FAIL_TO_WIPTE_LUCENE_INDEX_DIR("Failed to wipe Lucene index at directory: %s") | |||
| FAIL_TO_WIPTE_LUCENE_INDEX_DIR("Failed to wipe Lucene index at directory: %s"), | |||
There was a problem hiding this comment.
spelling error 'Wipe'
QubitPi
force-pushed
the
getLogicalTableFullView-with-filter
branch
from
1ce2df0 to
0849705
Compare
QubitPi
force-pushed
the
getLogicalTableFullView-with-filter
branch
from
0849705 to
53c6371
Compare
|
@archolewa Sure. Here is the issue, which I will address today - #560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3rd milestone implementation of #310 . This PR implements basics. There are the following issues that could bring improvements:
For @archolewa's request, API doc also needs to be updated