-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate doc, built-in-makers.md, to Chinese #499
Translate doc, built-in-makers.md, to Chinese #499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, very nice translation! Make sure to add a link to the original doc that references to this translation, like that in top level README
@@ -0,0 +1,80 @@ | |||
内置制造机 Built In Makers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“内置数据度量建造器” is a better translation than “内置制造机”, since Makers
are all about metric. Change all instances of the translations below, as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
@@ -0,0 +1,80 @@ | |||
内置制造机 Built In Makers | |||
=============== | |||
下面是一个Fili内置标准制造机表格。对于标准制造机,请参考[Configuring Metrics][configuring metrics]。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Configuring Metrics][configuring metrics] is not rendered correctly. please look at the bottom section of this file where I left a comment
--------------------------------------- | ||
|
||
下列制造机用于制造一级标准,且与下面表格中的操作一一对应。 | ||
[Druid aggregations][druid aggregations]。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Druid aggregations][druid aggregations] is not rendered correctly, please look at the bottom section of this file where I left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
Druid集合操作制造机 | ||
--------------------------------------- | ||
|
||
下列制造机用于制造一级标准,且与下面表格中的操作一一对应。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fili talks to Druid. Fili provides all aggregation functionalities that Druid has. Given that, "且与下面表格中的操作一一对应" shall be made better by saying "和Druid数据聚合功能一一对应".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
|
||
<sub><a name="countCaveat">1</a>: 实际上`计数器制造机CountMaker`并不直接翻译成Druid的计数集合操作,因为实现`计数器制造机CountMaker`的时候,Druid内部有一个bug。`计数器制造机CountMaker`的内部实现是创建一个多重查询。内层查询对每一个值为1的行加入一个常熟。外部查询则对该常数执行`长整数之和longSum`。 | ||
|
||
[集合平均制造机AggregationAverageMaker]: ../fili-core/src/main/java/com/yahoo/bard/webservice/data/config/metric/makers/AggregationAverageMaker.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section, if you look at the actual rendering of this doc, is not showing. They are link references and are, hence, not to be translated
建造操作制造机 | ||
--------------------------------- | ||
|
||
这些制造机代表了一些并不能被单词Druid(后)集合操作完成的操作。他们可能会创建新的列,限制Druid查询的规模,或者是在集合操作之上的数学表达(比如平均数)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
数学表达 -> 进一步数学运算
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
现在,我们只支持一个这样的内置标准制造机: | ||
|
||
1. [`集合平均制造机AggregationAverageMaker`][集合平均制造机AggregationAverageMaker]: | ||
`集合平均制造机`允许我们在一个维度上进行集合操作,然后取更广维度的集合后的标准之平均数。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
允许我们在一个维度上进行集合操作 -> 可以在一个精度上聚合一个方面的数据
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
|
||
1. [`集合平均制造机AggregationAverageMaker`][集合平均制造机AggregationAverageMaker]: | ||
`集合平均制造机`允许我们在一个维度上进行集合操作,然后取更广维度的集合后的标准之平均数。 | ||
`集合平均制造机` 比较复杂,而且有[其自己的文档][aggregationAverageMaker-docs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在这之前有些没翻译
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which ones?
详细说明。 | ||
|
||
|
||
<sub><a name="countCaveat">1</a>: 实际上`计数器制造机CountMaker`并不直接翻译成Druid的计数集合操作,因为实现`计数器制造机CountMaker`的时候,Druid内部有一个bug。`计数器制造机CountMaker`的内部实现是创建一个多重查询。内层查询对每一个值为1的行加入一个常熟。外部查询则对该常数执行`长整数之和longSum`。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
翻译成 -> 对应
详细说明。 | ||
|
||
|
||
<sub><a name="countCaveat">1</a>: 实际上`计数器制造机CountMaker`并不直接翻译成Druid的计数集合操作,因为实现`计数器制造机CountMaker`的时候,Druid内部有一个bug。`计数器制造机CountMaker`的内部实现是创建一个多重查询。内层查询对每一个值为1的行加入一个常熟。外部查询则对该常数执行`长整数之和longSum`。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
内层查询对每一个值为1的行加入一个常熟 -> 内层查询在每一个返回的结果列里插入一个值为1的常数列
Is this still in progress? Does someone need to adopt it? |
@michael-mclawhorn I'm contacting the translator and ask him to update |
@@ -0,0 +1,81 @@ | |||
内置建造器 Built In Makers | |||
=============== | |||
下面是一个Fili内置标准建造器表格。对于标准建造器,请参考[`Configuring Metrics`][configuring metrics]。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer not to translate concepts likeMetric
,Dimension
. If it must be translated, I rather prefer to use "指标列" for Metrics
to be consistence with Druid translation 。Reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included both Chinese and English version. I think this would be a better choice.
Druid后集合操作建造器 | ||
-------------------------------------------- | ||
|
||
下列建造器在查询上使用单次Druid后集合运算符。这些运算符对应Druid的后期数据聚合操作。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post-aggregation should translate to "后聚合".
Also:
下列建造器在查询上使用单次Druid后集合运算符
could be
下列这些建造器在查询上应用了一次Druid后聚合运算符。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
Druid集合操作建造器 | ||
--------------------------------------- | ||
|
||
下列建造器用于制造一级标准,和Druid数据聚合功能一一对应。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下列建造器用于制造一级标准
Could be
如下列举的是一些一级指标制造器,它们和Druid数据聚合功能一一对应。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
|
||
3. [`Sketch集合运算建造器SketchSetOperationMaker`][Sketch集合运算建造器SketchSetOperationMaker] - 是[Druid sketch module][sketch module]的一部分。 | ||
|
||
我们现在并不支持源生Druid `JavaScript` 及 `HyperUnique Cardinality`后集合运算符。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
post aggregators could be "后聚合器".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
3. [`Sketch集合运算建造器SketchSetOperationMaker`][Sketch集合运算建造器SketchSetOperationMaker] - 是[Druid sketch module][sketch module]的一部分。 | ||
|
||
我们现在并不支持源生Druid `JavaScript` 及 `HyperUnique Cardinality`后集合运算符。 | ||
Fili支持sketches而不是hyperUnique对象,因为二者功能重复。`JavaScript`后运算符在大规模运行中会造成性能瓶颈。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
我们现在并不支持源生Druid `JavaScript` 及 `HyperUnique Cardinality`后集合运算符。 | ||
Fili支持sketches而不是hyperUnique对象,因为二者功能重复。`JavaScript`后运算符在大规模运行中会造成性能瓶颈。 | ||
|
||
建造操作建造器 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, Constructed Operations
here means operations constructed with multiple aggregators or with high complexity. So I suggest translating Constructed Operations
to "高复杂度运算" or "自定义运算".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Constructed Operations -> 自定义 is the word I was looking for. Thanks!
@tarrantzhang In order to let non-Chinese core team members to understand as much as possible, please use English whenever possible. |
@@ -7,7 +7,7 @@ details on metric makers. | |||
Makers for Druid Aggregation Operations | |||
--------------------------------------- | |||
|
|||
These makers are used to make first-level metrics, and are in a one-to-one mapping to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your editor may automatically changed this file (deleting padding spaces). We should avoid changing like this and keep this whole file untouched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines should not be added or deleted. Removing trailing spaces is fine, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add those trailing spaces back if necessary.
3. [`Sketch集合运算建造器SketchSetOperationMaker`][Sketch集合运算建造器SketchSetOperationMaker] - 是[Druid sketch module][sketch module]的一部分。 | ||
|
||
我们现在并不支持源生Druid `JavaScript` 及 `HyperUnique Cardinality`后聚合器。 | ||
Fili支持sketches而不是hyperUnique对象,因为二者功能重复。`JavaScript`后聚合器在大规模运行中会造成性能瓶颈。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure if
which handle the same problem domain
in the original doc should be translated to
因为二者功能重复
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this translation should be OK.
lgtm 👍 |
Your PR should not include other people's commit. I suggest you roll back your branch to the point (e.g. 020605c) before you merge with other's. Then you should first syn your master with upstream, and rebase your branch on top of it. |
b221012
to
9c2a5fb
Compare
@tarrantzhang Fixed |
2ab6baf
to
40dad68
Compare
950d508
to
f610ce0
Compare
Please comment & review!