Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Hide folder aliases defined using link: from outdated dependencies when using yarn upgrade-interactive #5393

Closed
2 tasks done
lensbart opened this issue Apr 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@lensbart
Copy link
Contributor

lensbart commented Apr 19, 2023

Previously flagged in #3112 (closed as stale)
Previously flagged in #2865 (closed as stale)
Could be alleviated by yarnpkg/yarn#3368

  • I'd be willing to implement this feature (contributing guide)
  • This feature is important to have in this repository; a contrib plugin wouldn't do

Describe the user story

Following the example given at https://yarnpkg.com/features/protocols#why-is-the-link-protocol-recommended-over-aliases-for-path-mapping, if you define an alias for your src folder as follows in package.json:

{
  "dependencies": {
    "src": "link:./src"
  }
}

and subsequently run yarn upgrade-interactive, it will confusingly show the src dependency as being out-of-date with the NPM package of the same name:

   src ----------------------------------------- ◉ link:./src -- ◯ link:./src::… ◯ ^1.1.2 -------

Describe the solution you'd like

I think this behaviour is confusing, because the src folder and src NPM package are completely unrelated, except for the fact that they have the same name. Therefore, I think linked folders should be excluded from the list of dependencies to upgrade.

Describe the drawbacks of your solution

None that I can think of

Describe alternatives you've considered

None

@lensbart lensbart added the enhancement New feature or request label Apr 19, 2023
arcanis added a commit that referenced this issue May 16, 2023
…dependencies (#5442)

* fix(plugin-interactive-tools): don’t list folder aliases as outdated dependencies

See #5393

* fix(plugin-interactive-tools): lint

* Versions

---------

Co-authored-by: Maël Nison <nison.mael@gmail.com>
@merceyz
Copy link
Member

merceyz commented May 16, 2023

Fixed in #5442

@merceyz merceyz closed this as completed May 16, 2023
merceyz pushed a commit that referenced this issue May 16, 2023
…dependencies (#5442)

* fix(plugin-interactive-tools): don’t list folder aliases as outdated dependencies

See #5393

* fix(plugin-interactive-tools): lint

* Versions

---------

Co-authored-by: Maël Nison <nison.mael@gmail.com>
arcanis added a commit to yarnpkg/example-repo-zipn that referenced this issue Jul 3, 2023
…dependencies (#5442)

* fix(plugin-interactive-tools): don’t list folder aliases as outdated dependencies

See yarnpkg/berry#5393

* fix(plugin-interactive-tools): lint

* Versions

---------

Co-authored-by: Maël Nison <nison.mael@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants