-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional dependencies #3575
Conditional dependencies #3575
Conversation
This comment has been minimized.
This comment has been minimized.
30a3b02
to
c2b775c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just finished a quick review - I looked at a bit of everything except the tests.
I'll do a more in-depth review (including the tests) once you resolve these comments.
Nit: In the PR description you wrote Optional peer dependencies don't have their checksum computed nor stored.
, it should be Conditional dependencies
.
Co-authored-by: Paul Soporan <paul.soporan@gmail.com>
Co-authored-by: Paul Soporan <paul.soporan@gmail.com>
Co-authored-by: Paul Soporan <paul.soporan@gmail.com>
I released this change in |
Reverted the avoidable breaking changes in #3612 so plugin authors shouldn't notice much if they're not using |
What's the problem this PR addresses?
Fixes #3317
How did you fix it?
I'll write in more details tomorrow, but in a few words:
supportedArchitectures
setting.--check-cache
will still validate them, for zero-install users.Note that while it contains breaking changes, I plan to land it as a minor. This is due to multiple factors:
Checklist