fix: revert breaking changes from conditional dependencies #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
changed the title
merceyz
force-pushed
the
merceyz/fix/revert-breaking-change
branch
from
6b54476 to
8dcf500
Compare
paul-soporan
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
This is not pretty at all but I guess it's what we've got to do to avoid introducing breaking changes 😦.
Can you add a "cleanup all of this" entry to #3591 too?
13 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
#3575 introduced some breaking changes that could have been avoided
Cache.fetchPackageFromCachehad itsskipIntegrityCheckoption moved from the third argument "options bag" to a fourth argument "options bag"FetchOptions.skipIntegrityCheckwas ignored by all the fetchersHow did you fix it?
FetchOptions.skipIntegrityCheckChecklist