-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused --save option for set resolution command #5868
fix: remove unused --save option for set resolution command #5868
Conversation
The option was never implemented in berry, but it's mentioned in the docs as well as in the CLI output. See yarnpkg#2202 I don't have the expertise to actually implement the flag, so the second best thing to do here is to remove it, so that people are no longer mislead.
aa5a616
to
7fb65d9
Compare
I am not completely sure if there should be some other packages bumped as well. Is upgrading only |
You need to bump |
Dependencies of @yarnpkg/cli are not bumped or declined here, waiting for more info in the discussion on yarnpkg#5868 Co-Authored-By: Clement Yan <clemyan@users.noreply.github.com>
You can leave those as The reason you need to bump Most other workspaces only have dev dependency on |
The only workspaces that have a non-dev dependency on `@yarnpkg/cli` are `@yarnpkg/doctor` and `@yarnpkg/builder` but neither of these is affected by the change in `SetResolutionCommand`. Co-Authored-By: Clement Yan <clemyan@users.noreply.github.com>
Awesome, thank you very much for the thorough explanation 👍 |
The option was never implemented in berry, but it's mentioned in the docs as well as in the CLI output.
I don't have the expertise to actually implement the flag, so the second best thing to do here is to remove it, so that people are no longer mislead.
What's the problem this PR addresses?
Mitigates #2202 (actual resolution should be implementing the flag).
How did you fix it?
Removed unnecessary flag.
Checklist