Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused --save option for set resolution command #5868

Merged
merged 3 commits into from
Nov 2, 2023
Merged

fix: remove unused --save option for set resolution command #5868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fb65d9
fix: remove unused --save option for set resolution command
akwodkiewicz Nov 1, 2023
f911b7f
fix: bump @yarnpkg/cli due to @yarnpkg/plugin-essentials bump
akwodkiewicz Nov 2, 2023
04d892e
fix: mark all the other dependant packages as non-bumped (declined)
akwodkiewicz Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .yarn/versions/3bcde5b8.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
releases:
"@yarnpkg/cli": patch
"@yarnpkg/plugin-essentials": patch

declined:
- "@yarnpkg/plugin-compat"
- "@yarnpkg/plugin-constraints"
- "@yarnpkg/plugin-dlx"
- "@yarnpkg/plugin-init"
- "@yarnpkg/plugin-interactive-tools"
- "@yarnpkg/plugin-nm"
- "@yarnpkg/plugin-npm-cli"
- "@yarnpkg/plugin-pack"
- "@yarnpkg/plugin-patch"
- "@yarnpkg/plugin-pnp"
- "@yarnpkg/plugin-pnpm"
- "@yarnpkg/plugin-stage"
- "@yarnpkg/plugin-typescript"
- "@yarnpkg/plugin-version"
- "@yarnpkg/plugin-workspace-tools"
- "@yarnpkg/builder"
- "@yarnpkg/core"
- "@yarnpkg/doctor"
6 changes: 1 addition & 5 deletions packages/plugin-essentials/sources/commands/set/resolution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default class SetResolutionCommand extends BaseCommand {
details: `
This command updates the resolution table so that \`descriptor\` is resolved by \`resolution\`.

Note that by default this command only affect the current resolution table - meaning that this "manual override" will disappear if you remove the lockfile, or if the package disappear from the table. If you wish to make the enforced resolution persist whatever happens, add the \`-s,--save\` flag which will also edit the \`resolutions\` field from your top-level manifest.
Note that by default this command only affect the current resolution table - meaning that this "manual override" will disappear if you remove the lockfile, or if the package disappear from the table. If you wish to make the enforced resolution persist whatever happens, edit the \`resolutions\` field in your top-level manifest.

Note that no attempt is made at validating that \`resolution\` is a valid resolution entry for \`descriptor\`.
`,
Expand All @@ -24,10 +24,6 @@ export default class SetResolutionCommand extends BaseCommand {
]],
});

save = Option.Boolean(`-s,--save`, false, {
description: `Persist the resolution inside the top-level manifest`,
});

descriptor = Option.String();
resolution = Option.String();

Expand Down