Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install with 'latest' tag, installs as version string 'latest' #1306

Closed
kwelch opened this issue Oct 20, 2016 · 6 comments · Fixed by #2471
Closed

Install with 'latest' tag, installs as version string 'latest' #1306

kwelch opened this issue Oct 20, 2016 · 6 comments · Fixed by #2471

Comments

@kwelch
Copy link
Contributor

kwelch commented Oct 20, 2016

Yarn: v0.16.1
Node: v6.2.0

Command ran:
yarn add <package>@latest
Actual result (in package.json)
"<package>": "latest"
Expected Result
"<package>": "^7.0.0"

I would lean on the side of this is a feature request to gain parity with this command: npm install --save <package>@latest

@aethant
Copy link

aethant commented Oct 24, 2016

Ill see if I can take a look.

@aethant
Copy link

aethant commented Oct 24, 2016

@samccone I'm working on implementing this, however, I'm wondering where (if anywhere) I might be able to access the requested repo's dist tags, i.e. - npm info <package> dist-tags. That way, the code would support all dist-tags, not just latest.

@akshbn
Copy link

akshbn commented Oct 25, 2016

Hi! i have fixed this issue. @aethant Is it ok if i send a PR for this? or do you want to do this on your own?
I am fine with both.

Apologies for going ahead with the fix even though you had taken it. I was very excited to contribute to this project and this seemed like a low hanging fruit.

@aethant
Copy link

aethant commented Oct 25, 2016

Just submit your PR.

@DenisGorbachev
Copy link
Contributor

@akshbn this bug is still unfixed - could you please submit your PR?

@danielkcz
Copy link

Yarn version 0.18.0 and bug is still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants