show version number of a package in package.json and yarn.lock inplace of dist-tag #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyze
suggested changes
Nov 7, 2016
|
Sure! Will do this by the coming weekend. |
|
@akshbn Looks like your coming weekend that happened month ago got busy. What about this weekend? Would love to see this merged :) |
|
This got fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed the logic in savePackages function of add.js to replace the dist-tag with its version number.
Also since the lockfile is written before the patterns can be changed in the savePackages(), the lockfile should be written again with the modified pattern.
This PR addresses issue #1306