yarn no longer saves git/github packages in offline mirror #3154
Comments
|
I'm getting the same issue when yarn tries to resolve From my current
|
|
Note I get the correct behavior when using: Also the entires in v0.23.2: vs v0.21.3: |
|
Is it still an issue, @agibralter ? The |
|
@arcanis please see my comment above as I was using yarn v0.23 which couldn't get |
|
@arcanis I just tested with |
I don't see how anyone has offline mirror working in |
|
I've been keeping my eye on this issue hoping for it to get resolved. I've been using v0.21.3 for a while now because offline mirror functionality seems to be completely broken in newer releases, and I was running into the same issues as you, @agibralter. Among other reasons, I too rely on offline mirror to cache copies of my internal git dependencies so I don't have to massively overcomplicate my CI process. I'd really love to see this fixed sooner than later so I'm not stuck on this old version of yarn. |
|
For what it's worth, I've had some success with 0.22.0. It seems to have slightly inconsistent behavior about when it outputs a URL to yarn.lock vs. when it outputs a filename... |
|
The offline mirror works fine, at least for regular packages. I'm not sure we have a unit test for git repositories, which might explain why something could have broke here :/ Definitely something we should add (PR accepted, if you're faster than us :). I've tried to reproduce your issues, and:
I'm sorry for the problems you've experienced, we'll do our best to fix it in the next tagged release. |
|
@arcanis Ok now I'm confused—I'm getting different behavior in my app's project than I am on a fresh project. I created this: https://github.com/agibralter/yarn-test/blob/master/test.sh I can confirm that with that script I get: When I run it on my project I get: However, I realized that we have Strange thing is, though, that when I add |
|
Ooh, I'm realizing that a lock file never got created because of the error... |
|
Ok I've rebuilt my script to be more robust on a different branch: https://github.com/agibralter/yarn-test/tree/offline-mode-broken I can reliably reproduce the broken behavior with git and also npm scoped repos: |
|
I think the problem I may have been seeing was the "with pruning" true + git. It seems to silently fail... |
|
I believe there's a mismatch between the new |
|
Also, it seems that in no circumstances will |
|
@arcanis any thoughts on the script I created? Do you get the same behavior when you run it? |
|
Yep, I'm on it 👍 |
|
Fyi, we're cutting the 0.25 release, which will not ship with a fix. There's various issues in play here, and I'd like to make the patch right, so it will probably ship in the next patch release. I'll keep you updated. |
|
😭 😄 okie dokie |
|
Is there any update to this... I really don't want to get stuck on |
|
@arcanis hi there! Any sense on this issue? Is there anything I can do to help? |
|
@agibralter This issue should be fixed by #3449 (already merged) and #3548 (soon-to-be-merged), which will both be released at the end of the week. Sorry for the delay! |
|
Any updates here? Looks like those got merged. Is there a release? |
|
Yep, just waiting for #3578 to be reviewed and merged, otherwise the Windows artifacts won't be correctly generated. Should be tomorrow! |
|
@agibralter We just published the 0.26.1 release! Could you please try and confirm that it fixes the issue on your side? 🙏 |
|
@arcanis works for me with something like: |
|
@arcanis appears to be working now 🎉🎉🎉 Thank you!!! |
Do you want to request a feature or report a bug?
bug
What is the current behavior?
Given our
./package.jsonlike this:{ "dependencies": { "@kadira/react-storybook-addon-info": "^3.3.0", "@kadira/storybook-ui": "^3.11.0", "internal-pkg": "git+ssh://git@github.com/me/internal-pkg.git#abcdef0", ... } }And
./.yarnrc:Running
yarnno longer seems to save the dependencies from github/git in ournpm_cache.If the current behavior is a bug, please provide the steps to reproduce.
What is the expected behavior?
Running
lson the./vendor/npm_cacheshould include non-npm-hosted packages.Please mention your node.js, yarn and operating system version.
macOS 10.12.4:
(Node is installed via
nvmandyarnviabrew)The text was updated successfully, but these errors were encountered: