Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitFetcher fetchFromLocal compares the wrong hashes #3198

Closed
jaredru opened this issue Apr 20, 2017 · 4 comments
Closed

GitFetcher fetchFromLocal compares the wrong hashes #3198

jaredru opened this issue Apr 20, 2017 · 4 comments

Comments

@jaredru
Copy link

jaredru commented Apr 20, 2017

Do you want to request a feature or report a bug?
Report a bug.

What is the current behavior?
GitFetcher fetchFromLocal compares the git commit hash with the hash of the tarball itself. So, installing this way fails:

❯ yarn
yarn install v0.23.2
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error Bad hash. Expected "a43715a08af0b06ac140db652da0c09dc6eacf01" but got "86e25a19f2ae5d44ca5de710a2775a71f6c3f35f" 
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

In this case, "a43715a08af0b06ac140db652da0c09dc6eacf01" is the git commit of the git dependency. "86e25a19f2ae5d44ca5de710a2775a71f6c3f35f" is the hash of the tarball in the mirror.

If the current behavior is a bug, please provide the steps to reproduce.
Attempt to install a git dependency that exists in a local mirror.

What is the expected behavior?
The proper hashes are compared, and the install succeeds.

Please mention your node.js, yarn and operating system version.
Node: v4.9.0
Yarn: v0.23.2
OS: macOS 10.12.4

@WoodyWoodsta
Copy link

See #3109 as well.

@bestander
Copy link
Member

@arcanis is on this, we should fix it soom

@BYK
Copy link
Member

BYK commented Oct 27, 2017

@arcanis were you able to fix this on master?

@arcanis
Copy link
Member

arcanis commented Oct 30, 2017

Yes, this has been fixed in 0.23 (#3449)

@arcanis arcanis closed this as completed Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants