Disables the hash check for git repositories #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
added a commit
that referenced
this pull request
May 23, 2017
arcanis
added a commit
that referenced
this pull request
May 23, 2017
Ngo-The-Trung
pushed a commit
to Ngo-The-Trung/yarn
that referenced
this pull request
May 30, 2017
Following up yarnpkg#3449 expectHash is used beforehand to generate the cache destination, but actualHash is returned. This causes future cache destination path generation to use the wrong hash, resulting in EOENT errors.
Ngo-The-Trung
pushed a commit
to Ngo-The-Trung/yarn
that referenced
this pull request
May 31, 2017
Following up yarnpkg#3449 expectHash is used beforehand to generate the cache destination, but actualHash is returned. This causes future cache destination path generation to use the wrong hash, resulting in EOENT errors.
arcanis
pushed a commit
that referenced
this pull request
Jun 2, 2017
Following up #3449 expectHash is used beforehand to generate the cache destination, but actualHash is returned. This causes future cache destination path generation to use the wrong hash, resulting in EOENT errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
this.hashis equal to the commit hash inside the git fetcher, we have nothing against which compare the tarball hash. Fixing this will require fixing the lockfile structure (discussion here), so in the meantime it's better to just disable this check.Note that it wasn't a problem before 0.23, because until we merged #51 the offline
resolvedentry only contained the tarball name, which conveniently didn't included the hash. Since there was no hash, no check was made.