-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarn Workspaces - binaries are linked incorrectly #4359
Comments
Ca anyone help with this? It prevents us switching to workspaces. |
I can still reproduce this after the various workspaces fixes in yarn 1.2.0. |
To clarify the STR slightly, it looks like the bug only occurs if ie:
Expected: Actual: |
Thanks everyone for handling this, I really appreciate it. Can't wait to upgrade the version and try again! |
**Summary** Fixes yarnpkg#4706, fixes yarnpkg#4359, refs yarnpkg#4513. `this.config.cwd` was being used as the root for bin link paths, rather than `this.config.lockfileFolder`. **Test plan** - Added tests for `add` and `remove` commands (yarnpkg#4706) - Added test for `install` command (yarnpkg#4359)
I just hit the same problem. Is this released yet? |
I have encountered a similar problem, but was able to reproduce it while running a regular |
Do you want to request a feature or report a bug?
Report a bug
What is the current behavior?
When using Yarn Workspaces, binaries are linked incorrectly when running
yarn install
in a specific package.Setup:
Steps:
run
yarn install
inside package-bA repo demonstrating the issue is here: https://github.com/ohana54/yarn-bug
Result:
package-b/node_modules/.bin/webpack
is linked topackage-a/node_modules/webpack/bin/webpack.js
What is the expected behavior?
package-b/node_modules/.bin/webpack
is linked to[root-folder]/node_modules/webpack/bin/webpack.js
Please mention your node.js, yarn and operating system version.
node v.6.11.0, yarn v1.0.1, Mac OSX 10.11.4
Note: this can also happen when the current state is correct, and then running
yarn add some-package
inside package-b.EDIT: simpler steps to reproduce
EDIT 2: copied the steps from the repo, added another way to reproduce
The text was updated successfully, but these errors were encountered: