fix(linker): use lockfileFolder when creating bin links #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edorivai OK, thanks for checking. I think that issue is probably related and will have a similar solution. |
|
@jgoz 👍 looking forward. With the exception of some minor issues, workspaces are very awesome until now! |
I can confirm that using the STR in #4359 (comment) this no longer reproduces for me using a build from this PR branch, when it did before under yarn 1.2.1 😺 🎉 |
|
Wow, this is great thank you! I'll also check #4289 with this patch. |
BYK
approved these changes
Oct 19, 2017
BYK
changed the title
This was referenced Oct 20, 2017
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
**Summary** Fixes yarnpkg#4706, fixes yarnpkg#4359, refs yarnpkg#4513. `this.config.cwd` was being used as the root for bin link paths, rather than `this.config.lockfileFolder`. **Test plan** - Added tests for `add` and `remove` commands (yarnpkg#4706) - Added test for `install` command (yarnpkg#4359)
This was referenced Nov 2, 2017
BYK
pushed a commit
that referenced
this pull request
Nov 20, 2017
**Summary** Partial resolution for #4543. Previously, when running `yarn run` the env PATH would be set to look in node_modules/.bin, however, in workspaces the root workspace .bin path was not being included. This PR adds the workspace root node_modules/.bin path after the individual package's path. This is generally needed because #4730 ensures bin links in a workspace will be at the workspace root. With this PR, you can now `yarn run` commands in an individual package again. **Test plan** Manually tested by adding a script that runs `echo $PATH`
This was referenced Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4706, fixes #4359, refs #4513.
this.config.cwdwas being used as the root for bin link paths, rather thanthis.config.lockfileFolder.Test plan
addandremovecommands (Root binaries get removed after installing a Workspace dependency #4706)installcommand (Yarn Workspaces - binaries are linked incorrectly #4359)